xtern commented on code in PR #6383: URL: https://github.com/apache/ignite-3/pull/6383#discussion_r2266988353
########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryType.java: ########## @@ -54,6 +54,18 @@ public enum SqlQueryType { /** A set of all query types. **/ public static final Set<SqlQueryType> ALL = EnumSet.allOf(SqlQueryType.class); + /** A set of types that {@link #hasRowSet() has row set}. */ Review Comment: Done, thanks ########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryType.java: ########## @@ -54,6 +54,18 @@ public enum SqlQueryType { /** A set of all query types. **/ public static final Set<SqlQueryType> ALL = EnumSet.allOf(SqlQueryType.class); + /** A set of types that {@link #hasRowSet() has row set}. */ + public static final Set<SqlQueryType> HAS_ROW_SET_TYPES = Arrays.stream(values()) + .filter(SqlQueryType::hasRowSet).collect(Collectors.toCollection(() -> EnumSet.noneOf(SqlQueryType.class))); + + /** A set of types that {@link #returnsAffectedRows() returns number of affected rows}. */ Review Comment: Done, thanks ########## modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/SqlQueryType.java: ########## @@ -54,6 +54,18 @@ public enum SqlQueryType { /** A set of all query types. **/ public static final Set<SqlQueryType> ALL = EnumSet.allOf(SqlQueryType.class); + /** A set of types that {@link #hasRowSet() has row set}. */ + public static final Set<SqlQueryType> HAS_ROW_SET_TYPES = Arrays.stream(values()) + .filter(SqlQueryType::hasRowSet).collect(Collectors.toCollection(() -> EnumSet.noneOf(SqlQueryType.class))); + + /** A set of types that {@link #returnsAffectedRows() returns number of affected rows}. */ + public static final Set<SqlQueryType> RETURNS_AFFECTED_ROWS_TYPES = Arrays.stream(values()) + .filter(SqlQueryType::returnsAffectedRows).collect(Collectors.toCollection(() -> EnumSet.noneOf(SqlQueryType.class))); + + /** A set of types that {@link #supportsWasApplied() returns boolean indiccating whether command was applied or not}. */ Review Comment: Done, thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org