sanpwc commented on code in PR #6373:
URL: https://github.com/apache/ignite-3/pull/6373#discussion_r2263185850


##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/PersistentTxStateVacuumizer.java:
##########
@@ -174,11 +175,18 @@ public CompletableFuture<PersistentTxStateVacuumResult> 
vacuumPersistentTxStates
                 .handle((unused, unusedEx) -> new 
PersistentTxStateVacuumResult(successful, 
vacuumizedPersistentTxnStatesCount.get()));
     }
 
-    private boolean expectedException(Throwable e) {
+    private static boolean expectedException(Throwable e) {
         return hasCause(e,
                 PrimaryReplicaMissException.class,
                 NodeStoppingException.class,
-                GroupOverloadedException.class
+                GroupOverloadedException.class,
+                // AwaitReplicaTimeoutException can be thrown from 
ReplicaService on receiver node, when there

Review Comment:
   Could you please also mention, that mentioned below only works if it's local 
call, which is true here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to