dant3 commented on code in PR #6396:
URL: https://github.com/apache/ignite-3/pull/6396#discussion_r2263109721
##########
modules/compatibility-tests/src/testFixtures/java/org/apache/ignite/internal/CompatibilityTestBase.java:
##########
@@ -164,8 +166,12 @@ protected List<List<Object>> sql(String query) {
return sql(node(0), query);
}
- protected List<List<Object>> sql(Ignite ignite, String query) {
- return ClusterPerClassIntegrationTest.sql(ignite, null, null, null,
query);
+ protected static List<List<Object>> sql(Ignite ignite, String query) {
+ return sql(ignite, null, query);
+ }
+
+ protected static List<List<Object>> sql(Ignite ignite, @Nullable
Transaction tx, String query) {
+ return ClusterPerClassIntegrationTest.sql(ignite, tx, null, null,
query);
Review Comment:
Lets also add `Object... args` passing here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
