denis-chudov commented on code in PR #6344:
URL: https://github.com/apache/ignite-3/pull/6344#discussion_r2262749888
##########
modules/raft/src/main/java/org/apache/ignite/raft/jraft/core/NodeImpl.java:
##########
@@ -1841,6 +1851,90 @@ public void handleReadIndexRequest(final
ReadIndexRequest request,
}
}
+ @Override
+ public void handleGetLeaderAndTermRequest(GetLeaderRequest request,
RpcResponseClosure<GetLeaderResponse> done) {
+ final long startMs = Utils.monotonicMs();
+ this.readLock.lock();
+ try {
+ switch (this.state) {
+ case STATE_LEADER:
+ getLeaderFromLeader(done);
+ break;
+ case STATE_FOLLOWER:
+ getLeaderFromFollower(request, done);
+ break;
+ case STATE_TRANSFERRING:
+ done.run(new Status(RaftError.EBUSY, "Is transferring
leadership."));
+ break;
+ default:
+ done.run(new Status(RaftError.UNKNOWN, "Invalid state for
getLeaderAndTerm: %s.", this.state));
+ break;
+ }
+ }
+ finally {
+ this.readLock.unlock();
+ this.metrics.recordLatency("handle-get-leader",
Utils.monotonicMs() - startMs);
+ }
+ }
+
+ private void getLeaderFromFollower(GetLeaderRequest request,
RpcResponseClosure<GetLeaderResponse> closure) {
+ PeerId leaderId = this.leaderId;
+
+ if (leaderId == null || leaderId.isEmpty()) {
+ closure.run(new Status(RaftError.UNKNOWN, "No leader at term %d.",
this.currTerm));
+ return;
+ }
+ // send request to leader.
+ final GetLeaderRequest newRequest =
raftOptions.getRaftMessagesFactory()
+ .getLeaderRequest()
+ .groupId(request.groupId())
+ .peerId(leaderId.toString())
+ .build();
+
+ this.rpcClientService.getLeaderAndTerm(leaderId, newRequest, -1,
closure);
+ }
+
+ private void getLeaderFromLeader(RpcResponseClosure<GetLeaderResponse>
closure) {
+ PeerId leaderId = this.leaderId;
+
+ if (leaderId == null || leaderId.isEmpty()) {
+ closure.run(new Status(RaftError.UNKNOWN, "No leader at term %d.",
this.currTerm));
+ return;
+ }
+
+ GetLeaderResponseBuilder respBuilder =
raftOptions.getRaftMessagesFactory().getLeaderResponse()
+ .leaderId(leaderId.toString())
+ .currentTerm(this.getCurrentTerm());
+
+ final int quorum = getQuorum();
+ if (quorum <= 1) {
+ // Only one peer, fast path.
+ closure.setResponse(respBuilder.build());
+ closure.run(Status.OK());
+ return;
+ }
+
+ final List<PeerId> peers = this.conf.getConf().getPeers();
Review Comment:
`getLeaderFromLeader` is called within readLock, so it's ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
