xtern commented on code in PR #6380:
URL: https://github.com/apache/ignite-3/pull/6380#discussion_r2262438446
##########
modules/sql-engine/src/integrationTest/java/org/apache/ignite/internal/sql/engine/ItTemporalIndexTest.java:
##########
@@ -252,7 +252,7 @@ public void testSearchGtLtWithPkIdxUsage(String table,
String predicate, Object
for (String idx : SORTED_INDEXES.get(table)) {
assertQuery(format("SELECT /*+ FORCE_INDEX({}) */ val FROM {}
WHERE pk {} ORDER BY val",
idx, table, predicate))
- .matches(containsIndexScan("PUBLIC", table, idx))
+ .matches(containsIndexScanIgnoreBounds("PUBLIC", table,
idx))
Review Comment:
For me it looks like we need to improve a bit such tests 😔
We must ensure that for pk-index search bounds are present.
Possible solutions:
1. add `if (idx.equals(pkIndexName(table)))` and call containsIndexScan
2. (preferable) remove pk-indexes from SORTED_INDEXES indexes collection and
add separate pk check with containsIndexScan in each test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
