ibessonov commented on code in PR #6382:
URL: https://github.com/apache/ignite-3/pull/6382#discussion_r2260334175
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointPagesWriter.java:
##########
@@ -220,26 +228,33 @@ private void writeDirtyPage(
PersistentPageMemory pageMemory,
FullPageId pageId,
ByteBuffer tmpWriteBuf,
- PageStoreWriter pageStoreWriter
+ PageStoreWriter pageStoreWriter,
+ boolean useTryWriteLockLockOnPage
) throws IgniteInternalCheckedException {
// Should also be done for partitions that will be destroyed to remove
their pages from the data region.
- pageMemory.checkpointWritePage(pageId, tmpWriteBuf.rewind(),
pageStoreWriter, tracker);
+ pageMemory.checkpointWritePage(pageId, tmpWriteBuf.rewind(),
pageStoreWriter, tracker, true);
Review Comment:
Should it be `useTryWriteLockLockOnPage` instead of `true`?
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointPagesWriter.java:
##########
@@ -321,7 +336,7 @@ private void drainCheckpointBuffers(ByteBuffer tmpWriteBuf)
throws IgniteInterna
writePartitionMeta(pageMemory, partitionId,
tmpWriteBuf.rewind());
}
- pageMemory.checkpointWritePage(cpPageId,
tmpWriteBuf.rewind(), pageStoreWriter, tracker);
+ pageMemory.checkpointWritePage(cpPageId,
tmpWriteBuf.rewind(), pageStoreWriter, tracker, true);
Review Comment:
Please add a small comment that would explain why you prefer locking the
page here. I'm not sure that it's a right decision yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
