maksaska commented on code in PR #317: URL: https://github.com/apache/ignite-extensions/pull/317#discussion_r2255268647
########## modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/JavaToSqlTypeMapper.java: ########## @@ -0,0 +1,264 @@ +package org.apache.ignite.cdc.postgresql; + +import java.math.BigDecimal; +import java.sql.PreparedStatement; +import java.sql.Types; +import java.time.Duration; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.time.LocalTime; +import java.time.OffsetDateTime; +import java.time.OffsetTime; +import java.time.Period; +import java.util.HashMap; +import java.util.Map; +import java.util.UUID; +import org.apache.ignite.IgniteException; +import org.apache.ignite.internal.util.lang.RunnableX; + +/** */ +public class JavaToSqlTypeMapper { + /** */ + private static final int NO_SQL_TYPE = -1; + + /** */ + private static final Map<String, JavaToSqlType> JAVA_TO_SQL_TYPE_MAP = new HashMap<>(); + + static { + for (JavaToSqlType type : JavaToSqlType.values()) + JAVA_TO_SQL_TYPE_MAP.put(type.javaTypeName(), type); + } + + /** + * Sets a value in the PreparedStatement at the given index using the appropriate setter + * based on the runtime type of the object. + * @param stmt {@link PreparedStatement} + * @param idx value index in {@link PreparedStatement} + * @param obj value + */ + public void setEventFieldValue(PreparedStatement stmt, Integer idx, Object obj) { + if (obj == null) { + setSafe(() -> stmt.setNull(idx, Types.NULL)); + + return; + } + + int types = JAVA_TO_SQL_TYPE_MAP.get(obj.getClass().getName()).types(); + + if (types != -1) + setSafe(() -> stmt.setObject(idx, obj, types)); + else if (obj instanceof Duration) { + Duration dur = (Duration)obj; + + BigDecimal durVal = BigDecimal.valueOf(dur.getSeconds()).add(BigDecimal.valueOf(dur.getNano(), 9)); + + setSafe(() -> stmt.setBigDecimal(idx, durVal)); + } + else if (obj instanceof byte[]) + setSafe(() -> stmt.setBytes(idx, (byte[])obj)); + else + setSafe(() -> stmt.setObject(idx, obj)); + } + + /** + * Renders the SQL type for a given Java class name, including both precision and scale if supported. + * + * @param clsName The fully qualified Java class name (e.g., {@code java.math.BigDecimal}). + * @param precision The numeric precision to include in the SQL type declaration. + * @param scale The numeric scale to include in the SQL type declaration. + * @return A SQL type string (e.g., {@code DECIMAL (10, 2)}) corresponding to the given class and numeric metadata. + * If the SQL type does not support scale, {@link #renderSqlType(String, int)} is used instead. + */ + public String renderSqlType(String clsName, int precision, int scale) { + JavaToSqlType type = JAVA_TO_SQL_TYPE_MAP.get(clsName); + + if (!type.scale()) + return renderSqlType(clsName, precision); + + return type.sqlType().replace("?", String.format("(%d, %d)", precision, scale)); + } + + /** + * Renders the SQL type for a given Java class name, including precision if supported. + * + * @param clsName The fully qualified Java class name (e.g., {@code java.lang.String}). + * @param precision The numeric precision or length to include in the SQL type declaration. + * @return A SQL type string (e.g., {@code VARCHAR (255)}) corresponding to the given class and precision. + * If the SQL type does not support precision, {@link #renderSqlType(String)} is used instead. + */ + public String renderSqlType(String clsName, int precision) { + JavaToSqlType type = JAVA_TO_SQL_TYPE_MAP.get(clsName); + + if (!type.precision()) + return renderSqlType(clsName); + + return type.sqlType().replace("?", String.format("(%d)", precision)); + } + + /** + * Renders the SQL type for a given Java class name without any precision or scale. + * + * @param clsName The fully qualified Java class name (e.g., {@code java.lang.Integer}). + * @return A SQL type string (e.g., {@code INTEGER}, {@code VARCHAR}, or {@code DECIMAL}) with or without + * placeholders removed. If the mapped SQL type includes a precision placeholder, it will be removed. + */ + public String renderSqlType(String clsName) { + JavaToSqlType type = JAVA_TO_SQL_TYPE_MAP.get(clsName); + + if (type.precision()) + return type.sqlType().replace("?", ""); + + return type.sqlType(); + } + + /** + * Executes the given operation that may throw an exception, converting any thrown {@link Throwable} + * into an {@link IgniteException}. + * + * @param op the operation to execute, represented as a {@link RunnableX}. + * @throws IgniteException if the operation throws any exception. + */ + private void setSafe(RunnableX op) { Review Comment: Fixed ########## modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/JavaToSqlTypeMapper.java: ########## @@ -0,0 +1,264 @@ +package org.apache.ignite.cdc.postgresql; + +import java.math.BigDecimal; +import java.sql.PreparedStatement; +import java.sql.Types; +import java.time.Duration; +import java.time.LocalDate; +import java.time.LocalDateTime; +import java.time.LocalTime; +import java.time.OffsetDateTime; +import java.time.OffsetTime; +import java.time.Period; +import java.util.HashMap; +import java.util.Map; +import java.util.UUID; +import org.apache.ignite.IgniteException; +import org.apache.ignite.internal.util.lang.RunnableX; + +/** */ +public class JavaToSqlTypeMapper { + /** */ + private static final int NO_SQL_TYPE = -1; + + /** */ + private static final Map<String, JavaToSqlType> JAVA_TO_SQL_TYPE_MAP = new HashMap<>(); + + static { + for (JavaToSqlType type : JavaToSqlType.values()) + JAVA_TO_SQL_TYPE_MAP.put(type.javaTypeName(), type); + } + + /** + * Sets a value in the PreparedStatement at the given index using the appropriate setter + * based on the runtime type of the object. + * @param stmt {@link PreparedStatement} + * @param idx value index in {@link PreparedStatement} + * @param obj value + */ + public void setEventFieldValue(PreparedStatement stmt, Integer idx, Object obj) { Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org