Phillippko commented on code in PR #6363:
URL: https://github.com/apache/ignite-3/pull/6363#discussion_r2253980745
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -3065,22 +3073,33 @@ private CompletableFuture<Void>
destroyPartitionStorages(TablePartitionId tableP
destroyFutures.add(runAsync(() ->
internalTable.txStateStorage().destroyPartitionStorage(partitionId),
ioExecutor));
}
- destroyFutures.add(runAsync(() ->
destroyReplicationProtocolStorages(tablePartitionId, table), ioExecutor));
+ destroyFutures.add(
+ runAsync(() ->
destroyReplicationProtocolStorages(tablePartitionId, table,
destroyingWholeTable), ioExecutor)
+ );
}
// TODO: IGNITE-24926 - reduce set in localPartsByTableId after
storages destruction.
return allOf(destroyFutures.toArray(new CompletableFuture[]{}));
}
- private void destroyReplicationProtocolStorages(TablePartitionId
tablePartitionId, TableImpl table) {
+ private void destroyReplicationProtocolStorages(TablePartitionId
tablePartitionId, TableImpl table, boolean destroyingWholeTable) {
var internalTbl = (InternalTableImpl) table.internalTable();
- destroyReplicationProtocolStorages(tablePartitionId,
internalTbl.storage().isVolatile());
+ destroyReplicationProtocolStorages(tablePartitionId,
internalTbl.storage().isVolatile(), destroyingWholeTable);
}
- private void destroyReplicationProtocolStorages(TablePartitionId
tablePartitionId, boolean isVolatileStorage) {
+ private void destroyReplicationProtocolStorages(
+ TablePartitionId tablePartitionId,
+ boolean isVolatileStorage,
+ boolean destroyingWholeTable
+ ) {
try {
-
replicaMgr.destroyReplicationProtocolStoragesDurably(tablePartitionId,
isVolatileStorage);
+ if (destroyingWholeTable) {
Review Comment:
Don't insist, but could "durably" be a better name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
