sanpwc commented on code in PR #6350:
URL: https://github.com/apache/ignite-3/pull/6350#discussion_r2250678804
##########
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/MetricManagerImpl.java:
##########
@@ -247,6 +257,43 @@ public Collection<MetricExporter> enabledExporters() {
return inBusyLock(busyLock, enabledMetricExporters::values);
}
+ private static List<ExporterView> defaultExporters(List<? extends
ExporterView> configuredExporters) {
+ if
(configuredExporters.stream().map(ExporterView::exporterName).anyMatch(n ->
n.equals(LogPushExporter.EXPORTER_NAME))) {
Review Comment:
> If user defined an exporter with the exporterName logPush in configuration
(and the type of exporter is defined by exporterName), then the instance from
configuration will be used.
Still not sure that I properly got it. Do you assume that `logPush` is the
only possible default exporter?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
