tkalkirill commented on code in PR #6330:
URL: https://github.com/apache/ignite-3/pull/6330#discussion_r2239644828
##########
modules/low-watermark/src/main/java/org/apache/ignite/internal/lowwatermark/LowWatermarkImpl.java:
##########
@@ -339,16 +395,12 @@ CompletableFuture<Void> updateAndNotify(HybridTimestamp
newLowWatermark) {
.whenCompleteAsync((unused, throwable) -> {
if (throwable != null) {
if (!(hasCause(throwable,
NodeStoppingException.class))) {
- LOG.error("Failed to update low
watermark, will schedule again: {}", throwable, newLowWatermark);
+ LOG.error("Failed to update low
watermark: {}", throwable, newLowWatermark);
failureManager.process(new
FailureContext(CRITICAL_ERROR, throwable));
-
- inBusyLock(busyLock,
this::scheduleUpdateLowWatermarkBusy);
Review Comment:
We can update the bottom watermark both as a result of a scheduled task and
after installing a raft snapshot. Only scheduled tasks should schedule the next
update and not a raft snapshot, I thought it would be more correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
