rpuch commented on code in PR #6329:
URL: https://github.com/apache/ignite-3/pull/6329#discussion_r2239606387


##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/Loza.java:
##########
@@ -446,6 +448,43 @@ public void destroyRaftNodeStorages(RaftNodeId nodeId, 
RaftGroupOptions raftGrou
         }
     }
 
+    /**
+     * Destroys Raft group node storages (log storage, metadata storage and 
snapshots storage).
+     *
+     * <p>Destruction is durable: that is, if this method returns and after 
that the node crashes, after it starts up, the storage
+     * will not be there.
+     *
+     * @param nodeId ID of the Raft node.
+     * @param raftGroupOptions Group options.
+     * @throws NodeStoppingException If the node is already being stopped.
+     */
+    public void destroyRaftNodeStoragesDurably(RaftNodeId nodeId, 
RaftGroupOptions raftGroupOptions) throws NodeStoppingException {
+        if (!busyLock.enterBusy()) {

Review Comment:
   It's possible, but it's against the style already used in this class. I 
would like to avoid changing this in the whole class in this PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to