sashapolo commented on code in PR #6309:
URL: https://github.com/apache/ignite-3/pull/6309#discussion_r2235466824


##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -974,6 +997,42 @@ private CompletableFuture<List<BinaryRow>> 
retrieveExactEntriesUntilCursorEmpty(
         });
     }
 
+    private static void mergeRowsWithResolvedWriteIntents(
+            List<BinaryRow> rows,
+            Int2ObjectMap<CompletableFuture<TimedBinaryRow>> resolutionFutures,
+            List<BinaryRow> result
+    ) {
+        int curIndex = 0;
+        int rowsIndex = 0;
+
+        for (Entry<CompletableFuture<TimedBinaryRow>> entry : 
resolutionFutures.int2ObjectEntrySet()) {

Review Comment:
   > What if we pre-inserted null into an original list, and then instead of 
joining sub-lists we would just do a set in a loop? 
   
   This seems not possible, because a write intent can resolve into a `null` 
and we do not return nulls



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to