wernerdv commented on code in PR #12214:
URL: https://github.com/apache/ignite/pull/12214#discussion_r2227652404
##########
modules/compatibility/src/test/java/org/apache/ignite/compatibility/testframework/junits/IgniteCompatibilityAbstractTest.java:
##########
@@ -288,7 +288,11 @@ protected Set<String> getExcluded(String ver,
Collection<Dependency> dependencie
excluded.add("indexing");
// Exclude all modules necessary to compile the current version of
core module to avoid conflicts with previous versions.
- excluded.addAll(Set.of("binary", "codegen2", "commons", "unsafe"));
+ // When building with TeamCity, JAR files named according to their
artifact IDs are added to the classpath.
+ excluded.addAll(Set.of("ignite-binary-api", "ignite-binary-impl",
"ignite-commons", "ignite-grid-unsafe"));
Review Comment:
Initially, I added `codegen2` because it was listed as `compile` scope in
the pom.xml of the core module.
Now that it's marked as `provided` and tests pass successfully with the
current list of exclusions, adding codegen2 seems unnecessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
