korlov42 commented on code in PR #6263:
URL: https://github.com/apache/ignite-3/pull/6263#discussion_r2224410536
##########
modules/sql-engine/src/main/codegen/includes/parserImpls.ftl:
##########
@@ -629,16 +629,43 @@ void ZoneElement(List<SqlNode> zoneOptions) :
(
<SCALE>
(
- <UP> option = UnsignedIntegerLiteral()
- {
- key = new
SqlIdentifier(ZoneOptionEnum.DATA_NODES_AUTO_ADJUST_SCALE_UP.name(), pos);
- zoneOptions.add(new IgniteSqlZoneOption(key, option,
s.end(this)));
- }
+ <UP>
+ (
+ option = UnsignedIntegerLiteral()
+ {
+ key = new
SqlIdentifier(ZoneOptionEnum.DATA_NODES_AUTO_ADJUST_SCALE_UP.name(), pos);
+ zoneOptions.add(new IgniteSqlZoneOption(key, option,
s.end(this)));
+ }
+ |
+ <OFF>
+ {
+ key = new
SqlIdentifier(ZoneOptionEnum.DATA_NODES_AUTO_ADJUST_SCALE_UP.name(), pos);
+ zoneOptions.add(new IgniteSqlZoneOption(key,
IgniteSqlZoneOptionMode.SCALE_OFF.symbol(getPos()), s.end(this)));
+ }
+ )
|
- <DOWN> option = UnsignedIntegerLiteral()
+ <DOWN>
+ (
+ option = UnsignedIntegerLiteral()
+ {
+ key = new
SqlIdentifier(ZoneOptionEnum.DATA_NODES_AUTO_ADJUST_SCALE_DOWN.name(), pos);
+ zoneOptions.add(new IgniteSqlZoneOption(key, option,
s.end(this)));
+ }
+ |
+ <OFF>
+ {
+ key = new
SqlIdentifier(ZoneOptionEnum.DATA_NODES_AUTO_ADJUST_SCALE_DOWN.name(), pos);
+ zoneOptions.add(new IgniteSqlZoneOption(key,
IgniteSqlZoneOptionMode.SCALE_OFF.symbol(getPos()), s.end(this)));
+ }
+ )
+ |
+ <OFF>
Review Comment:
but why? currently, if you want to change both properties (`scale up` and
`scale down`) at once, you use auto `adjust <N>`. Why disabling scale should be
different?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
