rpuch commented on code in PR #6297:
URL: https://github.com/apache/ignite-3/pull/6297#discussion_r2222828606


##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/storage/impl/DefaultLogStorageFactory.java:
##########
@@ -360,6 +369,49 @@ private static ColumnFamilyOptions 
createColumnFamilyOptions() {
         return opts;
     }
 
+    @Override
+    public Set<String> raftNodeStorageIdsOnDisk(GroupIdFastForward 
fastForward) {
+        Set<String> groupIdsForStorage = new HashSet<>();
+
+        byte[] upperBound = incrementPrefix(STORAGE_CREATED_META_PREFIX);
+
+        try (
+                Slice upperBoundSlice = new Slice(upperBound);
+                ReadOptions readOptions = new 
ReadOptions().setIterateUpperBound(upperBoundSlice);
+                RocksIterator iterator = db.newIterator(metaHandle, 
readOptions)
+        ) {
+            iterator.seek(STORAGE_CREATED_META_PREFIX);
+
+            while (iterator.isValid()) {

Review Comment:
   I added a comment explaining that this method should only be called when 
groups cannot appear/be destroyed concurrently



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to