maksaska commented on code in PR #311: URL: https://github.com/apache/ignite-extensions/pull/311#discussion_r2217360629
########## modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/IgniteToPostgreSqlCdcApplier.java: ########## @@ -0,0 +1,661 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.cdc.postgresql; + +import java.math.BigDecimal; +import java.nio.ByteBuffer; +import java.nio.ByteOrder; +import java.sql.Connection; +import java.sql.PreparedStatement; +import java.sql.SQLException; +import java.sql.Statement; +import java.sql.Types; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Iterator; +import java.util.Map; +import java.util.Set; +import java.util.UUID; +import javax.sql.DataSource; +import org.apache.ignite.IgniteException; +import org.apache.ignite.IgniteLogger; +import org.apache.ignite.binary.BinaryObject; +import org.apache.ignite.cache.CacheEntryVersion; +import org.apache.ignite.cache.QueryEntity; +import org.apache.ignite.cdc.CdcCacheEvent; +import org.apache.ignite.cdc.CdcEvent; +import org.apache.ignite.internal.util.typedef.F; + +import static org.apache.ignite.internal.processors.cache.GridCacheUtils.UNDEFINED_CACHE_ID; + +/** */ +public class IgniteToPostgreSqlCdcApplier { + /** */ + public static final String DFLT_SQL_TYPE = "OTHER"; + + /** */ + public static final Map<String, String> JAVA_TO_SQL_TYPES; + + static { + Map<String, String> map = new HashMap<>(); + + map.put("java.lang.String", "VARCHAR"); + map.put("java.lang.Integer", "INT"); + map.put("int", "INT"); + map.put("java.lang.Long", "BIGINT"); + map.put("long", "BIGINT"); + map.put("java.lang.Boolean", "BOOLEAN"); + map.put("boolean", "BOOLEAN"); + map.put("java.lang.Double", "DOUBLE PRECISION"); + map.put("double", "DOUBLE PRECISION"); + map.put("java.lang.Float", "REAL"); + map.put("float", "REAL"); + map.put("java.math.BigDecimal", "DECIMAL"); + map.put("java.lang.Short", "SMALLINT"); + map.put("short", "SMALLINT"); + map.put("java.lang.Byte", "SMALLINT"); + map.put("byte", "SMALLINT"); + map.put("java.util.UUID", "UUID"); + map.put("[B", "BYTEA"); + map.put("java.lang.Object", "OTHER"); + + JAVA_TO_SQL_TYPES = Collections.unmodifiableMap(map); + } + + /** */ + private final DataSource dataSrc; + + /** */ + private final boolean autoCommit; + + /** */ + private final long maxBatchSize; + + /** */ + private final IgniteLogger log; + + /** */ + private final Map<Integer, String> cacheIdToUpsertQry = new HashMap<>(); + + /** */ + private final Map<Integer, String> cacheIdToDeleteQry = new HashMap<>(); + + /** */ + private final Map<Integer, Set<String>> cacheIdToPrimaryKeys = new HashMap<>(); + + /** */ + private final Map<Integer, Set<String>> cacheIdToFields = new HashMap<>(); + + /** */ + private final Set<Object> curKeys = new HashSet<>(); + + /** + * @param dataSrc {@link DataSource} - connection pool to PostgreSql + * @param autoCommit - autoCommit flag for batch execution + * @param maxBatchSize the maximum number of CDC events to include in a single batch + * @param log the {@link IgniteLogger} instance used for logging CDC processing events + */ + public IgniteToPostgreSqlCdcApplier(DataSource dataSrc, boolean autoCommit, long maxBatchSize, IgniteLogger log) { + this.dataSrc = dataSrc; + this.autoCommit = autoCommit; + this.maxBatchSize = maxBatchSize; + this.log = log; + } + + /** + * @param evts an {@link Iterator} of {@link CdcEvent} objects to be applied + * @return the total number of events successfully batched and executed + */ + public long applyEvents(Iterator<CdcEvent> evts) { + try (Connection conn = dataSrc.getConnection()) { + conn.setAutoCommit(autoCommit); + + long res = applyEvents(conn, evts); + + conn.commit(); + + return res; + } + catch (Throwable e) { + log.error(e.getMessage(), e); + + throw new IgniteException("CDC failure", e); + } + } + + /** + * @param conn connection to PostgreSql + * @param evts an {@link Iterator} of {@link CdcEvent} objects to be applied + * @return the total number of events successfully batched and executed + */ + private long applyEvents(Connection conn, Iterator<CdcEvent> evts) { + long evtsApplied = 0; + + int currCacheId = UNDEFINED_CACHE_ID; + boolean prevOpIsDelete = false; + + PreparedStatement curPrepStmt = null; + CdcEvent evt; + + while (evts.hasNext()) { + evt = evts.next(); + + if (log.isDebugEnabled()) + log.debug("Event received [evt=" + evt + ']'); + + if (currCacheId != evt.cacheId() || prevOpIsDelete ^ (evt.value() == null)) { + if (curPrepStmt != null) + evtsApplied += executeBatch(curPrepStmt); + + currCacheId = evt.cacheId(); + prevOpIsDelete = evt.value() == null; + + curPrepStmt = prepareStatement(conn, evt); + } + + if (curKeys.size() >= maxBatchSize || curKeys.contains(evt.key())) + evtsApplied += executeBatch(curPrepStmt); + + addEvent(curPrepStmt, evt); + } + + if (currCacheId != UNDEFINED_CACHE_ID) + evtsApplied += executeBatch(curPrepStmt); + + return evtsApplied; + } + + /** + * @param curPrepStmt {@link PreparedStatement} + * @return the total number of batches successfully executed. One CdcEvent - one batch. + */ + private int executeBatch(PreparedStatement curPrepStmt) { + try { + curKeys.clear(); + + if (log.isDebugEnabled()) + log.debug("Applying batch " + curPrepStmt.toString()); + + if (!curPrepStmt.isClosed()) + return curPrepStmt.executeBatch().length; + + throw new IgniteException("Tried to execute on closed prepared statement!"); + } + catch (SQLException e) { + log.error(e.getMessage(), e); + + throw new IgniteException(e); + } + } + + /** + * @param conn connection to PostgreSql + * @param evt {@link CdcEvent} + * @return relevant {@link PreparedStatement} + */ + private PreparedStatement prepareStatement(Connection conn, CdcEvent evt) { + String sqlQry; + + if (evt.value() == null) + sqlQry = cacheIdToDeleteQry.get(evt.cacheId()); + else + sqlQry = cacheIdToUpsertQry.get(evt.cacheId()); + + if (sqlQry == null) + throw new IgniteException("No SQL query is found for cacheId=" + evt.cacheId()); + + if (log.isDebugEnabled()) + log.debug("Statement updated [cacheId=" + evt.cacheId() + ", sqlQry=" + sqlQry + ']'); + + try { + return conn.prepareStatement(sqlQry); + } + catch (SQLException e) { + log.error(e.getMessage(), e); + + throw new IgniteException(e); + } + } + + /** + * @param curPrepStmt {@link PreparedStatement} + * @param evt {@link CdcEvent} + */ + private void addEvent(PreparedStatement curPrepStmt, CdcEvent evt) { + try { + if (evt.value() == null) + addEvent(curPrepStmt, evt, true); + else { + int idx = addEvent(curPrepStmt, evt, false); + + curPrepStmt.setBytes(idx, encodeVersion(evt.version())); + } + + curPrepStmt.addBatch(); + } + catch (Throwable e) { + log.error(e.getMessage(), e); + + throw new IgniteException(e); + } + } + + /** + * @param curPrepStmt {@link PreparedStatement} + * @param evt {@link CdcEvent} + * @param isDelete - flag that indicate delete sql statement usage + * @return number of filled values Review Comment: Refactored this part ########## modules/cdc-ext/src/main/java/org/apache/ignite/cdc/postgresql/IgniteToPostgreSqlCdcApplier.java: ########## @@ -0,0 +1,661 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.cdc.postgresql; + +import java.math.BigDecimal; +import java.nio.ByteBuffer; +import java.nio.ByteOrder; +import java.sql.Connection; +import java.sql.PreparedStatement; +import java.sql.SQLException; +import java.sql.Statement; +import java.sql.Types; +import java.util.Collections; +import java.util.HashMap; +import java.util.HashSet; +import java.util.Iterator; +import java.util.Map; +import java.util.Set; +import java.util.UUID; +import javax.sql.DataSource; +import org.apache.ignite.IgniteException; +import org.apache.ignite.IgniteLogger; +import org.apache.ignite.binary.BinaryObject; +import org.apache.ignite.cache.CacheEntryVersion; +import org.apache.ignite.cache.QueryEntity; +import org.apache.ignite.cdc.CdcCacheEvent; +import org.apache.ignite.cdc.CdcEvent; +import org.apache.ignite.internal.util.typedef.F; + +import static org.apache.ignite.internal.processors.cache.GridCacheUtils.UNDEFINED_CACHE_ID; + +/** */ +public class IgniteToPostgreSqlCdcApplier { + /** */ + public static final String DFLT_SQL_TYPE = "OTHER"; + + /** */ + public static final Map<String, String> JAVA_TO_SQL_TYPES; + + static { + Map<String, String> map = new HashMap<>(); + + map.put("java.lang.String", "VARCHAR"); + map.put("java.lang.Integer", "INT"); + map.put("int", "INT"); + map.put("java.lang.Long", "BIGINT"); + map.put("long", "BIGINT"); + map.put("java.lang.Boolean", "BOOLEAN"); + map.put("boolean", "BOOLEAN"); + map.put("java.lang.Double", "DOUBLE PRECISION"); + map.put("double", "DOUBLE PRECISION"); + map.put("java.lang.Float", "REAL"); + map.put("float", "REAL"); + map.put("java.math.BigDecimal", "DECIMAL"); + map.put("java.lang.Short", "SMALLINT"); + map.put("short", "SMALLINT"); + map.put("java.lang.Byte", "SMALLINT"); + map.put("byte", "SMALLINT"); + map.put("java.util.UUID", "UUID"); + map.put("[B", "BYTEA"); + map.put("java.lang.Object", "OTHER"); + + JAVA_TO_SQL_TYPES = Collections.unmodifiableMap(map); + } + + /** */ + private final DataSource dataSrc; + + /** */ + private final boolean autoCommit; + + /** */ + private final long maxBatchSize; + + /** */ + private final IgniteLogger log; + + /** */ + private final Map<Integer, String> cacheIdToUpsertQry = new HashMap<>(); + + /** */ + private final Map<Integer, String> cacheIdToDeleteQry = new HashMap<>(); + + /** */ + private final Map<Integer, Set<String>> cacheIdToPrimaryKeys = new HashMap<>(); + + /** */ + private final Map<Integer, Set<String>> cacheIdToFields = new HashMap<>(); + + /** */ + private final Set<Object> curKeys = new HashSet<>(); + + /** + * @param dataSrc {@link DataSource} - connection pool to PostgreSql + * @param autoCommit - autoCommit flag for batch execution + * @param maxBatchSize the maximum number of CDC events to include in a single batch + * @param log the {@link IgniteLogger} instance used for logging CDC processing events + */ + public IgniteToPostgreSqlCdcApplier(DataSource dataSrc, boolean autoCommit, long maxBatchSize, IgniteLogger log) { + this.dataSrc = dataSrc; + this.autoCommit = autoCommit; + this.maxBatchSize = maxBatchSize; + this.log = log; + } + + /** + * @param evts an {@link Iterator} of {@link CdcEvent} objects to be applied + * @return the total number of events successfully batched and executed + */ + public long applyEvents(Iterator<CdcEvent> evts) { + try (Connection conn = dataSrc.getConnection()) { + conn.setAutoCommit(autoCommit); + + long res = applyEvents(conn, evts); + + conn.commit(); + + return res; + } + catch (Throwable e) { + log.error(e.getMessage(), e); + + throw new IgniteException("CDC failure", e); + } + } + + /** + * @param conn connection to PostgreSql + * @param evts an {@link Iterator} of {@link CdcEvent} objects to be applied + * @return the total number of events successfully batched and executed + */ + private long applyEvents(Connection conn, Iterator<CdcEvent> evts) { + long evtsApplied = 0; + + int currCacheId = UNDEFINED_CACHE_ID; + boolean prevOpIsDelete = false; + + PreparedStatement curPrepStmt = null; + CdcEvent evt; + + while (evts.hasNext()) { + evt = evts.next(); + + if (log.isDebugEnabled()) + log.debug("Event received [evt=" + evt + ']'); + + if (currCacheId != evt.cacheId() || prevOpIsDelete ^ (evt.value() == null)) { + if (curPrepStmt != null) + evtsApplied += executeBatch(curPrepStmt); + + currCacheId = evt.cacheId(); + prevOpIsDelete = evt.value() == null; + + curPrepStmt = prepareStatement(conn, evt); + } + + if (curKeys.size() >= maxBatchSize || curKeys.contains(evt.key())) + evtsApplied += executeBatch(curPrepStmt); + + addEvent(curPrepStmt, evt); + } + + if (currCacheId != UNDEFINED_CACHE_ID) + evtsApplied += executeBatch(curPrepStmt); + + return evtsApplied; + } + + /** + * @param curPrepStmt {@link PreparedStatement} + * @return the total number of batches successfully executed. One CdcEvent - one batch. + */ + private int executeBatch(PreparedStatement curPrepStmt) { + try { + curKeys.clear(); + + if (log.isDebugEnabled()) + log.debug("Applying batch " + curPrepStmt.toString()); + + if (!curPrepStmt.isClosed()) + return curPrepStmt.executeBatch().length; + + throw new IgniteException("Tried to execute on closed prepared statement!"); + } + catch (SQLException e) { + log.error(e.getMessage(), e); + + throw new IgniteException(e); + } + } + + /** + * @param conn connection to PostgreSql + * @param evt {@link CdcEvent} + * @return relevant {@link PreparedStatement} + */ + private PreparedStatement prepareStatement(Connection conn, CdcEvent evt) { + String sqlQry; + + if (evt.value() == null) + sqlQry = cacheIdToDeleteQry.get(evt.cacheId()); + else + sqlQry = cacheIdToUpsertQry.get(evt.cacheId()); + + if (sqlQry == null) + throw new IgniteException("No SQL query is found for cacheId=" + evt.cacheId()); + + if (log.isDebugEnabled()) + log.debug("Statement updated [cacheId=" + evt.cacheId() + ", sqlQry=" + sqlQry + ']'); + + try { + return conn.prepareStatement(sqlQry); + } + catch (SQLException e) { + log.error(e.getMessage(), e); + + throw new IgniteException(e); + } + } + + /** + * @param curPrepStmt {@link PreparedStatement} + * @param evt {@link CdcEvent} + */ + private void addEvent(PreparedStatement curPrepStmt, CdcEvent evt) { + try { + if (evt.value() == null) + addEvent(curPrepStmt, evt, true); + else { + int idx = addEvent(curPrepStmt, evt, false); + + curPrepStmt.setBytes(idx, encodeVersion(evt.version())); + } + + curPrepStmt.addBatch(); + } + catch (Throwable e) { + log.error(e.getMessage(), e); + + throw new IgniteException(e); + } + } + + /** + * @param curPrepStmt {@link PreparedStatement} + * @param evt {@link CdcEvent} + * @param isDelete - flag that indicate delete sql statement usage Review Comment: Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
