lowka opened a new pull request, #6276:
URL: https://github.com/apache/ignite-3/pull/6276
Updates `ConfigurationTreeComparator` to check compatibility issues between
two nodes.
Checks roots and configuration kind separately.
`validateConfigNode` - compares two `ConfigNode`s
`validateChildNode` - compares two child `ConfigNode`s (single vs
polymorphic , polymorphic vs single, etc)
Polymorphic nodes tests:
- Extract polymorphic configuration ( 1 or multiple instances )
- Move a field from base configuration to instances.
- Move a field from all instances to base configuration.
- Add a new instance of a polymorphic configuration.
Fixes an issue with renaming non-leaf nodes because renaming non-leafs nodes
is also possible. Example:
```
\ConfigurationExtension
public class RestExtensionConfigurationSchema extends
NodeConfigurationSchema {
\PublicName("rest")
\ConfigValue
public RestConfigurationSchema unrest;
}
```
---
Thank you for submitting the pull request.
To streamline the review process of the patch and ensure better code quality
we ask both an author and a reviewer to verify the following:
### The Review Checklist
- [ ] **Formal criteria:** TC status, codestyle, mandatory documentation.
Also make sure to complete the following:
\- There is a single JIRA ticket related to the pull request.
\- The web-link to the pull request is attached to the JIRA ticket.
\- The JIRA ticket has the Patch Available state.
\- The description of the JIRA ticket explains WHAT was made, WHY and HOW.
\- The pull request title is treated as the final commit message. The
following pattern must be used: IGNITE-XXXX Change summary where XXXX - number
of JIRA issue.
- [ ] **Design:** new code conforms with the design principles of the
components it is added to.
- [ ] **Patch quality:** patch cannot be split into smaller pieces, its size
must be reasonable.
- [ ] **Code quality:** code is clean and readable, necessary developer
documentation is added if needed.
- [ ] **Tests code quality:** test set covers positive/negative scenarios,
happy/edge cases. Tests are effective in terms of execution time and resources.
### Notes
- [Apache Ignite Coding
Guidelines](https://cwiki.apache.org/confluence/display/IGNITE/Java+Code+Style+Guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
