alex-plekhanov commented on code in PR #11977:
URL: https://github.com/apache/ignite/pull/11977#discussion_r2213569010
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/rel/MergeJoinNode.java:
##########
@@ -1006,27 +942,24 @@ else if (cmp > 0) {
inLoop = false;
}
- if (waitingRight == 0)
- rightSource().request(waitingRight = IN_BUFFER_SIZE);
+ if (requested > 0 && leftFinished() && rightFinished(true) &&
checkJoinFinished())
+ return;
- if (waitingLeft == 0)
- leftSource().request(waitingLeft = IN_BUFFER_SIZE);
-
- if (requested > 0 && waitingLeft == NOT_WAITING && left == null &&
leftInBuf.isEmpty()
- && waitingRight == NOT_WAITING && right == null &&
rightInBuf.isEmpty() && rightMaterialization == null
- )
- checkJoinFinished();
+ tryToRequestInputs();
}
}
/** */
- private static class SemiJoin<Row> extends MergeJoinNode<Row> {
- /** */
- private Row left;
+ protected void tryToRequestInputs() throws Exception {
Review Comment:
Move before or after all join classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
