Vladsz83 commented on code in PR #12113:
URL: https://github.com/apache/ignite/pull/12113#discussion_r2210248149
##########
modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/metadata/IgniteMdColumnOrigins.java:
##########
@@ -92,33 +88,10 @@ public class IgniteMdColumnOrigins implements
MetadataHandler<BuiltInMetadata.Co
return set;
}
- /** */
- public @Nullable Set<RelColumnOrigin> getColumnOrigins(Join rel,
RelMetadataQuery mq,
- int iOutputColumn) {
- int nLeftColumns = rel.getLeft().getRowType().getFieldList().size();
- Set<RelColumnOrigin> set;
- boolean derived = false;
-
- if (iOutputColumn < nLeftColumns) {
- set = mq.getColumnOrigins(rel.getLeft(), iOutputColumn);
-
- if (rel.getJoinType().generatesNullsOnLeft())
- derived = true;
-
- }
- else {
- set = mq.getColumnOrigins(rel.getRight(), iOutputColumn -
nLeftColumns);
-
- if (rel.getJoinType().generatesNullsOnRight())
- derived = true;
- }
-
- if (derived) {
- // nulls are generated due to outer join; that counts
- // as derivation
- set = createDerivedColumnOrigins(set);
- }
- return set;
Review Comment:
All these methods just copy `RelMdColumnOrigins`. Also are removed in AI3. I
suggest the same: keep only changed methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
