sanpwc commented on code in PR #6118: URL: https://github.com/apache/ignite-3/pull/6118#discussion_r2207174275
########## modules/cluster-management/src/main/java/org/apache/ignite/internal/cluster/management/network/messages/CmgPrepareInitMessage.java: ########## @@ -0,0 +1,33 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.ignite.internal.cluster.management.network.messages; + +import org.apache.ignite.internal.network.NetworkMessage; +import org.apache.ignite.internal.network.annotations.Transferable; + +/** + * Message for initializing the Cluster Management Group. Review Comment: > It seems that it's about preparing for initialization. Javadoc changed from `Message for initializing the Cluster Management Group` to `Message for the Cluster Management Group initialization preparation.`. > Would it make sense to document here how preparation is different from initialization itself? I don't think that it should be documented here. However there are comments in `ClusterInitializer` `// Within prepareInitMessage we validate that all CMG nodes have enabledColocation mode.` and in `ClusterManagementGroupManager` ``` /** * Handles the prepare init messages. * * <p>If both initiator node and recipient have same colocation mode PrepareInitCompleteMessage is sent, * otherwise InitErrorMessage is sent. */ private void handlePrepareInit(CmgPrepareInitMessage msg, ClusterNode sender, long correlationId) { ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
