alex-plekhanov commented on code in PR #12180:
URL: https://github.com/apache/ignite/pull/12180#discussion_r2200505588


##########
modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/planner/MergeJoinPlannerTest.java:
##########
@@ -2794,6 +2797,26 @@ public void testInnerDeriveMixed2() throws Exception {
         assertNull(sortOnTopOfScan(rel, "RIGHT_T"));
     }
 
+    /** */
+    @Test
+    public void testMergeJoinIsNotAppliedForNonEquiJoin() throws Exception {
+        IgniteSchema schema = createSchema(
+            createTable("EMP", 1000, IgniteDistributions.broadcast(),
+                "ID", INTEGER, "NAME", VARCHAR, "DEPTNO", INTEGER)
+                .addIndex("emp_idx", 1, 2),
+            createTable("DEPT", 100, IgniteDistributions.broadcast(),
+                "DEPTNO", INTEGER, "NAME", VARCHAR)
+                .addIndex("dep_idx", 1, 0)

Review Comment:
   Here we check that condition `e.name >= d.name` is not applied for merge 
join even if we have a index on it. So 0, 1 will be incorrect test case ('name' 
should be first field in index)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to