sashapolo commented on code in PR #6229:
URL: https://github.com/apache/ignite-3/pull/6229#discussion_r2197529302


##########
modules/storage-rocksdb/src/main/java/org/apache/ignite/internal/storage/rocksdb/RocksDbStorageEngine.java:
##########
@@ -270,4 +273,24 @@ public void destroyMvTable(int tableId) {
             rocksDbStorage.rocksDbInstance.destroyTable(tableId);
         }
     }
+
+    @Override
+    public Set<Integer> tableIdsOnDisk() {
+        return storageByProfileName.values().stream()
+                .flatMap(storage -> 
storage.rocksDbInstance.tableIdsInRocksDb().stream())
+                .collect(toUnmodifiableSet());
+    }
+
+    /**
+     * Flushes all changes made to the underlying RocksDB instances to disk.
+     *
+     * @return Future that gets completed when flush is complete.
+     */
+    public CompletableFuture<Void> flush() {
+        @SuppressWarnings("rawtypes")
+        CompletableFuture[] futures = storageByProfileName.values().stream()

Review Comment:
   you can write `CompletableFuture<?>[] futures` and the raw types warning 
will go away



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to