alievmirza commented on code in PR #6210:
URL: https://github.com/apache/ignite-3/pull/6210#discussion_r2195191237
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/JraftGroupEventsListener.java:
##########
@@ -29,8 +30,16 @@ public interface JraftGroupEventsListener {
* Invoked, when a new leader is elected (if it is the first leader of
group ever - will be invoked too).
*
* @param term Raft term of the current leader.
+ * @param configurationTerm Term on which the current configuration was
applied.
+ * @param configurationIndex Index on which the current configuration was
applied.
+ * @param configuration Raft configuration on the moment of leader
election.
*/
- void onLeaderElected(long term);
+ void onLeaderElected(
Review Comment:
I'm a bit confused that all other methods have `Collection<PeerId> peers,
Collection<PeerId> learners`, but here we introduce `Configuration
configuration`
##########
modules/distribution-zones/src/integrationTest/java/org/apache/ignite/internal/rebalance/ItRebalanceByPendingAssignmentsQueueTest.java:
##########
@@ -405,7 +409,11 @@ private Set<Assignment> stablePartitionAssignments(String
tableName) {
private static void putPendingAssignments(Ignite ignite, String tableName,
AssignmentsQueue pendingAssignmentsQueue) {
ByteArray pendingKey =
pendingPartitionAssignmentsKey(partitionGroupId(ignite, tableName, 0));
byte[] pendingVal = pendingAssignmentsQueue.toBytes();
- unwrapIgniteImpl(ignite).metaStorageManager().put(pendingKey,
pendingVal).join();
+
+ ByteArray pendingChangeTriggerKey =
pendingChangeTriggerKey(partitionGroupId(ignite, tableName, 0));
+ byte[] pendinChangeTriggerKeyValue =
unwrapIgniteImpl(ignite).clock().now().toBytes();
+ var keyValsToUpdate = Map.of(pendingKey, pendingVal,
pendingChangeTriggerKey, pendinChangeTriggerKeyValue);
+
unwrapIgniteImpl(ignite).metaStorageManager().putAll(keyValsToUpdate).join();
Review Comment:
I would suggest to use assert + `willCompleteSuccessfully` instead of join
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
