AMashenkov commented on code in PR #6213:
URL: https://github.com/apache/ignite-3/pull/6213#discussion_r2194691581
##########
modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigurationTreeComparator.java:
##########
@@ -130,13 +155,19 @@ private static List<ConfigNode> getPath(ConfigNode node) {
*/
private static boolean match(ConfigNode node, ConfigNode candidate) {
return Objects.equals(candidate.kind(), node.kind())
- && Objects.equals(candidate.name(), node.name())
+ && (Objects.equals(candidate.name(), node.name())
+ || (node.isValue() && candidate.isValue() &&
compareUsingLegacyNames(candidate, node)))
Review Comment:
Let's extract this 2 lines into a separate method `matchNames(...)`
Why do we preform this check for `isValue` only? Is is possible to rename a
whole subtree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
