ygerzhedovich commented on code in PR #6203:
URL: https://github.com/apache/ignite-3/pull/6203#discussion_r2194285811


##########
modules/sql-engine/src/test/java/org/apache/ignite/internal/sql/engine/planner/AbstractTpcQueryPlannerTest.java:
##########
@@ -118,6 +120,12 @@ static void validateQueryPlan(String queryId) {
 
         String expectedPlan = planLoader.apply(queryId);
 
+        // Internally, costs are represented by double values and convertion 
to exact numeric representation may differs from JVM to JVM.
+        // 
https://www.oracle.com/java/technologies/javase/19-relnote-issues.html
+        // Cut-off costs, which may differ between runs, before comparing 
plans.
+        expectedPlan = COSTS_PATTERN.matcher(expectedPlan).replaceAll("");

Review Comment:
   Can we do it only for JDK 19+ ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to