rpuch commented on code in PR #6199:
URL: https://github.com/apache/ignite-3/pull/6199#discussion_r2191675367


##########
modules/catalog-dsl/src/integrationTest/java/org/apache/ignite/internal/catalog/ItCatalogApiThreadingTest.java:
##########
@@ -49,12 +62,49 @@ protected int initialNodes() {
         return 1;
     }
 
+    @BeforeAll
+    void waitForDefaultZoneStabilization() throws InterruptedException {
+        if (colocationEnabled()) {
+            awaitAssignmentsStabilization(node(0));

Review Comment:
   We should think about this really hard as doing this wait on each and every 
cluster startup will probably make integration tests run a lot longer.
   
   Also, it seems that for most tests this is not a problem (at least, for now 
there are only 3 tests in AI3 that require this, mine is 4th). So maybe, until 
the root cause is fixed, we can live with this.
   
   Also, even if we decide to do something about this, I think this should not 
concern this PR as it's about an unrelated thing and it's already pretty big. I 
suggest to start with extracting the method in a follow-up PR and see how it 
goes. If it turns out that we need to add this in many tests, we could 
prioritize  the root cause (https://issues.apache.org/jira/browse/IGNITE-25283) 
or choose another strategy, maybe adding the wait on each cluster init.
   
   WDYT?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to