denis-chudov commented on code in PR #6180:
URL: https://github.com/apache/ignite-3/pull/6180#discussion_r2185528777
##########
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/exporters/jmx/JmxExporter.java:
##########
@@ -173,7 +164,7 @@ private void unregBean(ObjectName bean) {
try {
ManagementFactory.getPlatformMBeanServer().unregisterMBean(bean);
} catch (JMException e) {
- log.error("Failed to unregister MBean: " + bean, e);
+ log.error("Failed to unregister MBean [bean=" + bean + ", err=" +
e.getMessage() + ']', e);
Review Comment:
you can use `IgniteLogger#error(java.lang.String, java.lang.Throwable,
java.lang.Object...)` instead of concatenation
##########
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/AbstractMetricSource.java:
##########
@@ -45,14 +51,35 @@ public abstract class AbstractMetricSource<T extends
AbstractMetricSource.Holder
* @param name Metric source name.
*/
protected AbstractMetricSource(String name) {
+ this(name, null, null);
+ }
+
+ /**
+ * Base constructor for all metric source implementations.
+ *
+ * @param name Metric source name.
Review Comment:
maybe add parameters to javadoc?
##########
modules/metrics/src/main/java/org/apache/ignite/internal/metrics/sources/StripedThreadPoolMetricSource.java:
##########
@@ -27,19 +28,40 @@
import org.apache.ignite.internal.metrics.LongGauge;
import org.apache.ignite.internal.metrics.Metric;
import org.apache.ignite.internal.thread.StripedThreadPoolExecutor;
+import org.jetbrains.annotations.Nullable;
/** Metric source for monitoring of {@link
org.apache.ignite.internal.thread.StripedThreadPoolExecutor}. */
Review Comment:
FQN here is no more needed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
