ibessonov commented on code in PR #6147:
URL: https://github.com/apache/ignite-3/pull/6147#discussion_r2180226530
##########
modules/runner/src/test/java/org/apache/ignite/internal/configuration/compatibility/framework/ConfigurationTreeComparator.java:
##########
@@ -19,20 +19,27 @@
import static org.junit.jupiter.api.Assertions.assertEquals;
+import java.util.ArrayList;
+import java.util.Collection;
+import java.util.Collections;
import java.util.List;
+import java.util.Objects;
+import java.util.function.Consumer;
+import java.util.stream.Collectors;
/**
* Compares two configuration trees (snapshot and current).
*/
public class ConfigurationTreeComparator {
Review Comment:
Alright, do we have unit tests for these validators and comparators? It
should be pretty straightforward to construct a bunch of `ConfigNode` instances
for many, many cases and check that it's all good. Can you please add such
tests or point me to them? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
