Cyrill commented on code in PR #6099:
URL: https://github.com/apache/ignite-3/pull/6099#discussion_r2177029336
##########
modules/transactions/src/main/java/org/apache/ignite/internal/tx/impl/TxCleanupRequestHandler.java:
##########
@@ -118,10 +118,9 @@ public TxCleanupRequestHandler(
public void start() {
messagingService.addMessageHandler(
TxMessageGroup.class,
- message -> cleanupExecutor,
(msg, sender, correlationId) -> {
if (msg instanceof TxCleanupMessage) {
- processTxCleanup((TxCleanupMessage) msg, sender,
correlationId);
+ cleanupExecutor.execute(() ->
processTxCleanup((TxCleanupMessage) msg, sender, correlationId));
Review Comment:
According to the javadoc,
> The chooser will NOT be used for self-requests (that is, if the
destination node is the same as current node). In such cases, handlers will be
invoked in the same thread that initiated the send.
In that case the request will still be processed in the ms thread. So I
changed the code to explicitly invoke another executor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
