sashapolo commented on code in PR #6150: URL: https://github.com/apache/ignite-3/pull/6150#discussion_r2174811195
########## modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/leases/LeaseTracker.java: ########## @@ -174,64 +172,89 @@ private class UpdateListener implements WatchListener { @Override public CompletableFuture<Void> onUpdate(WatchEvent event) { return inBusyLockAsync(busyLock, () -> { - List<CompletableFuture<?>> fireEventFutures = new ArrayList<>(); - List<Lease> expiredLeases = new ArrayList<>(); + var eventsToFire = new ArrayList<Supplier<CompletableFuture<?>>>(); - for (EntryEvent entry : event.entryEvents()) { - Entry msEntry = entry.newEntry(); + long eventRevision = event.revision(); - byte[] leasesBytes = msEntry.value(); + byte[] leasesBytes = event.entryEvent().newEntry().value(); Review Comment: This assertion is already present in the `entryEvent` method: ``` public EntryEvent entryEvent() { assert single() : entryEvts; return entryEvts.get(0); } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org