sk0x50 commented on code in PR #6136:
URL: https://github.com/apache/ignite-3/pull/6136#discussion_r2174655905
##########
modules/raft/src/main/java/org/apache/ignite/internal/raft/RaftGroupServiceImpl.java:
##########
@@ -615,11 +613,21 @@ private <R extends NetworkMessage> CompletableFuture<R>
sendWithRetry(
ThrottlingContextHolder peerThrottlingContextHolder =
throttlingContextHolder.peerContextHolder(peer.consistentId());
if (throttleOnOverload && peerThrottlingContextHolder.isOverloaded()) {
- executor.schedule(
- () -> future.completeExceptionally(new
GroupOverloadedException(groupId, peer)),
- 100,
- TimeUnit.MILLISECONDS
- );
+ if (!busyLock.enterBusy()) {
Review Comment:
Well, all other stuff does not depend on the service's internal state. So, I
decided to reduce the code that should be executed under the lock.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
