ibessonov commented on code in PR #6115:
URL: https://github.com/apache/ignite-3/pull/6115#discussion_r2166798100
##########
modules/partition-replicator/src/integrationTest/java/org/apache/ignite/internal/partition/replicator/raft/ItZonePartitionRaftListenerRecoveryTest.java:
##########
@@ -548,7 +548,7 @@ private List<UUID>
applyRandomUpdateCommands(RaftGroupService raftGroupService,
return commands;
}
- private UpdateCommand createUpdateCommand(UUID id, int tableId) {
+ private UpdateCommandV2 createUpdateCommand(UUID id, int tableId) {
Review Comment:
I think that you don't even have to change the type here in particular, this
method can still return an old interface
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/replicator/PartitionReplicaListener.java:
##########
@@ -3459,7 +3459,7 @@ private static BinaryRowMessage
binaryRowMessage(BinaryRow row) {
.build();
}
- private UpdateAllCommand updateAllCommand(
+ private UpdateAllCommandV2 updateAllCommand(
Review Comment:
Maybe it's the same here and in other tests, but I don't mind these
replacements. I, myself, would try to minimize the impact even further
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
