sergey-chugunov-1985 commented on code in PR #12156:
URL: https://github.com/apache/ignite/pull/12156#discussion_r2163291157
##########
docs/_docs/key-value-api/transactions.adoc:
##########
@@ -85,6 +85,11 @@
include::code-snippets/cpp/src/transactions.cpp[tag=transactions-execution,inden
--
+[WARNING]
+====
+When using the `try-catch-finally` construct, make sure to call the `close()`
method for correct transaction closure, or use the `try-with-resources` block
as shown in the example above.
Review Comment:
Lets mention that `close` method should be called in `finally` section of
`try-catch-finally` statement.
##########
docs/_docs/perf-and-troubleshooting/handling-exceptions.adoc:
##########
@@ -246,3 +246,6 @@ include::{javaFile}[tag=failure-types,indent=0]
----
--
+=== Handling Exception When Executing ComputeTask Using ComputeTaskAdapter
+
+When executing a `ComputeTask` using `ComputeTaskAdapter` on client, an
exception may occur: “org.apache.ignite.IgniteException: Remote job threw user
exception (override or implement ComputeTask.result(..) method if you would
like to have automatic failover for this exception): Failed to execute job due
to unexpected runtime exception...” when receiving the first error from node.
To handle this exception automatically, it’s necessary to override the
ComputeTask.result(..) method implementation for processing `IgniteException`
related to failure in performing tasks on any node. Ensure proper completion of
`ComputeTask` execution.
Review Comment:
Lets restructure this paragraph.
First lets inform user that inside a ComputeTaskAdapter an IgniteException
could be thrown.
Then specify that when the exception is thrown, a specific log entry appears
in logs. Though we don't need to put the whole entry text in here, 'Remote job
threw user exception` should be enough.
And in the end add a warning that when this exception happened it is a
responsibility of a user to make sure that all other jobs from this task has
finished, and ComputeTaskAdapted doesn't provide such guarantees.
##########
docs/_docs/perf-and-troubleshooting/handling-exceptions.adoc:
##########
@@ -246,3 +246,6 @@ include::{javaFile}[tag=failure-types,indent=0]
----
--
+=== Handling Exception When Executing ComputeTask Using ComputeTaskAdapter
Review Comment:
How about `Handling Exceptions in Ignite Compute Grid` with a reference to
[this
](https://ignite.apache.org/docs/latest/distributed-computing/distributed-computing)
documentation section?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
