tkalkirill commented on code in PR #6098:
URL: https://github.com/apache/ignite-3/pull/6098#discussion_r2161823961


##########
modules/storage-page-memory/src/test/java/org/apache/ignite/internal/storage/pagememory/index/hash/AbstractPageMemoryHashIndexStorageTest.java:
##########
@@ -89,4 +96,49 @@ void testFragmentedIndexColumns() {
 
         assertThat(getAll(index, createIndexRow(serializer, new 
RowId(TEST_PARTITION), 1, "foo")), empty());
     }
+
+    private static Stream<Arguments> sizesForCollisionTest() {
+        return Stream.of(
+                Arguments.of(10, 200),
+                Arguments.of(100, 200),
+                Arguments.of(200, 10),
+                Arguments.of(200, 100)
+        );
+    }
+
+    @ParameterizedTest
+    @MethodSource("sizesForCollisionTest")
+    void testHashCollisionAndDifferentSizes(int firstSize, int secondSize) {
+        var index = (PageMemoryHashIndexStorage) 
createIndexStorage(INDEX_NAME, ColumnType.STRING);
+
+        int hash = 123;
+
+        partitionStorage.runConsistently(locker -> {
+            try {
+                int inlineSize = index.indexTree().inlineSize();
+
+                HashIndexRow firstHashIndexRow = new HashIndexRow(

Review Comment:
   It's just funny that you use `var` for closures but not for rows.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to