ptupitsyn commented on code in PR #6076:
URL: https://github.com/apache/ignite-3/pull/6076#discussion_r2161351183


##########
modules/client/src/main/java/org/apache/ignite/client/IgniteClientConfiguration.java:
##########
@@ -176,4 +180,16 @@ public interface IgniteClientConfiguration {
      * @return Operation timeout, in milliseconds.
      */
     long operationTimeout();
+
+    /**
+     * Gets the size of cache to store partition awareness metadata of sql 
queries, in number of entries.
+     * Default is {@value #DFLT_SQL_PARTITION_AWARENESS_METADATA_CACHE_SIZE}.
+     *
+     * <p>Every instance of {@link IgniteSql} has its own cache. Every unique 
pair of (defaultSchema, queryString) reserve 
+     * its own place in metadata cache, if metadata is available for this 
particular query. In general, metadata is available
+     * for queries which have equality predicate over all colocation columns, 
or which inserts the whole tuple.

Review Comment:
   > queries which have equality predicate over all colocation columns
   
   Let's try to explain this better. As a user, how can I affect this? Where is 
this equality predicate?



##########
modules/client/src/main/java/org/apache/ignite/client/IgniteClientConfiguration.java:
##########
@@ -176,4 +180,16 @@ public interface IgniteClientConfiguration {
      * @return Operation timeout, in milliseconds.
      */
     long operationTimeout();
+
+    /**
+     * Gets the size of cache to store partition awareness metadata of sql 
queries, in number of entries.
+     * Default is {@value #DFLT_SQL_PARTITION_AWARENESS_METADATA_CACHE_SIZE}.
+     *

Review Comment:
   ```suggestion
        *
        * <p>SQL partition awareness feature improves query performance by 
directing queries to the specific server nodes that hold the relevant data, 
minimizing network overhead. Ignite client builds the metadata cache during the 
initial query execution and leverages this cache to speed up subsequent queries.
        *
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to