valepakh commented on code in PR #6075:
URL: https://github.com/apache/ignite-3/pull/6075#discussion_r2156843153
##########
modules/compatibility-tests/src/integrationTest/java/org/apache/ignite/internal/RunnerNode.java:
##########
@@ -74,15 +79,42 @@ public static RunnerNode startNode(
boolean useTestDefaults = true;
if (useTestDefaults) {
- writeConfigurationFileApplyingTestDefaults(configStr, configPath,
DEFAULTS_PER_VERSION.get(igniteVersion));
+ Map<String, String> defaultsPerVersion =
DEFAULTS_PER_VERSION.get(igniteVersion);
+ writeConfigurationFileApplyingTestDefaults(
+ configStr,
+ configPath,
+ defaultsPerVersion != null ? defaultsPerVersion : DEFAULTS
+ );
} else {
writeConfigurationFile(configStr, configPath);
}
Process process = executeRunner(javaHome, argFile, configPath,
workDir, nodeName);
+ IgniteLogger processLogger = Loggers.forName(nodeName);
+ createStreamGrabber(process, processLogger, process::getInputStream,
"input");
+ createStreamGrabber(process, processLogger, process::getErrorStream,
"error");
return new RunnerNode(process);
}
+ private static Thread createStreamGrabber(
+ Process process,
+ IgniteLogger processLogger,
+ Supplier<InputStream> streamSupplier,
+ String grabberType
+ ) {
+ Thread streamGrabber = new Thread(
Review Comment:
When process exits, its stream ends, so we exit gracefully. So I guess we
can remove this logic.
Or we can keep it for better handling of thread interruptions from somewhere
else other than our own code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
