korlov42 commented on code in PR #6065:
URL: https://github.com/apache/ignite-3/pull/6065#discussion_r2156853644
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/prepare/pruning/PartitionPruningPredicate.java:
##########
@@ -191,12 +192,29 @@ public static <RowT> List<PartitionWithConsistencyToken>
prunePartitions(
// TODO: https://issues.apache.org/jira/browse/IGNITE-21543
// Remove after this issue makes it possible to have
CAST('uuid_str' AS UUID) as value.
- if (physicalType.spec() == ColumnType.UUID && !(node
instanceof RexDynamicParam)) {
+ ColumnType columnType = physicalType.spec();
+ if (columnType == ColumnType.UUID && !(node instanceof
RexDynamicParam)) {
return null;
}
Object val = getNodeValue(physicalType, node,
dynamicParameters);
+ // TODO https://issues.apache.org/jira/browse/IGNITE-19162
Ignite doesn't support precision more than 3 for temporal types.
+ if (val != null && (columnType == ColumnType.TIME
Review Comment:
we should make decision based on physical type of the column, not based on
the current value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
