Copilot commented on code in PR #6059:
URL: https://github.com/apache/ignite-3/pull/6059#discussion_r2152436759
##########
modules/compute/src/main/java/org/apache/ignite/internal/compute/task/DelegatingTaskExecution.java:
##########
@@ -77,4 +80,19 @@ public boolean marshalResult() {
return delegate.join().marshalResult();
}
+
+ @Override
+ public long hybridTimestamp() {
+ if (delegate.isCompletedExceptionally()) {
+ return NULL_HYBRID_TIMESTAMP;
+ }
+
+ TaskExecutionInternal<I, M, T, R> delegateNow = delegate.getNow(null);
+
+ if (delegateNow == null) {
+ throw new IllegalStateException("Task execution is not yet
completed, cannot retrieve hybrid timestamp.");
Review Comment:
Consider handling the scenario where delegate.getNow(null) returns null more
gracefully instead of immediately throwing an exception, if it is expected that
asynchronous flows might invoke hybridTimestamp() before completion.
```suggestion
return NULL_HYBRID_TIMESTAMP;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
