nizhikovprivate commented on code in PR #12133:
URL: https://github.com/apache/ignite/pull/12133#discussion_r2150101495
##########
modules/core/src/test/java/org/apache/ignite/internal/processors/cache/persistence/filename/CacheConfigStoragePathTest.java:
##########
@@ -156,18 +193,27 @@ else if (storage == null)
snpRootF.apply(storagePath(STORAGE_PATH_2))
));
- assertEquals(path != null ? 1 : 3, roots.size());
+ boolean idxPathUsed = idxStorage && idxPartMustExistsInSnapshot();
+
+ if (idxPathUsed)
+ roots.add(snpRootF.apply(storagePath(IDX_PATH)));
+
+ // Sanity check storagePath returns different paths.
+ assertEquals(path != null ? 1 : (idxPathUsed ? 4 : 3), roots.size());
// Root -> cache -> partition set.
Map<File, Map<String, Set<Integer>>> snpFiles = new HashMap<>();
// Collecting all partition files under each snapshot root.
- roots.forEach(snpRoot -> {
+ for (File snpRoot : roots) {
assertTrue(snpRoot.exists());
assertTrue(snpRoot.isDirectory());
+ Predicate<Path> pathPredicate = p ->
NodeFileTree.partitionFile(p.toFile())
Review Comment:
Personally, I don't have any preferences about naming.
But, our style guide states:
> Getters and setters should be implemented without is/get/set prefixes in
internal APIs.
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=57901455#CodingGuidelines-Gettersandsetters
Don't know, if this method match "getter" :)
Feel free to come up with the better naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
