JAkutenshi commented on code in PR #6031:
URL: https://github.com/apache/ignite-3/pull/6031#discussion_r2145044593
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaReservationFailedException.java:
##########
@@ -27,6 +27,15 @@
public class ReplicaReservationFailedException extends RuntimeException {
public static final long serialVersionUID = 33897490775763932L;
+ /**
+ * Constructor.
+ *
+ * @param message Exception message.
+ */
+ ReplicaReservationFailedException(String message) {
Review Comment:
I don't like this approach, better to pass arguments and format message
inside constructor. Instead we have custom message constructor and special
constructor, but effectively has different arguments for their messages. And
each is used only twice.
##########
modules/placement-driver/src/main/java/org/apache/ignite/internal/placementdriver/LeaseUpdater.java:
##########
@@ -475,14 +474,6 @@ private void updateLeaseBatchInternal() {
if (lease.isProlongable() && agreement.isAccepted()) {
Lease negotiatedLease = agreement.getLease();
- // Lease information is taken from lease tracker,
where it appears on meta storage watch updates, so it can
- // contain stale leases, if watch processing was
delayed for some reason. It is ok: negotiated lease is
- // guaranteed to be already written to meta storage
before negotiation begins, and in this case its start time
- // would be greater than lease's.
- assert negotiatedLease.getStartTime().longValue() >=
lease.getStartTime().longValue()
Review Comment:
Why to remove this assertion? Why it's related to the scenario?
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -580,7 +580,7 @@ public TableManager(
schemaVersions = new
SchemaVersionsImpl(executorInclinedSchemaSyncService, catalogService,
clockService);
- tablesVv = new IncrementalVersionedValue<>(registry);
+ tablesVv = new IncrementalVersionedValue<>(registry, 100, null);
Review Comment:
Why this change matters?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
