AMashenkov commented on code in PR #6011:
URL: https://github.com/apache/ignite-3/pull/6011#discussion_r2144844960
##########
modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/jdbc/JdbcMetadataCatalog.java:
##########
@@ -211,30 +279,31 @@ public CompletableFuture<Collection<String>>
getSchemasMeta(String schemaNamePtr
* @param tbl Table.
* @return Jdbc primary key metadata.
*/
- private JdbcPrimaryKeyMeta createPrimaryKeyMeta(CatalogTableDescriptor
tbl) {
+ private static JdbcPrimaryKeyMeta createPrimaryKeyMeta(String schemaName,
CatalogTableDescriptor tbl) {
String keyName = PK + tbl.name();
List<String> keyColNames = List.copyOf(tbl.primaryKeyColumns());
- return new JdbcPrimaryKeyMeta(SqlCommon.DEFAULT_SCHEMA_NAME,
tbl.name(), keyName, keyColNames);
+ return new JdbcPrimaryKeyMeta(schemaName, tbl.name(), keyName,
keyColNames);
}
/**
* Creates column metadata from column and table name.
*
+ * @param schemaName Schema name.
* @param tblName Table name.
- * @param col Column.
+ * @param col Column descriptor.
* @return Column metadata.
*/
- private JdbcColumnMeta createColumnMeta(String tblName, Column col) {
- NativeType colType = col.type();
+ private static JdbcColumnMeta createColumnMeta(String schemaName, String
tblName, CatalogTableColumnDescriptor col) {
+ NativeType colType = TypeUtils.columnType2NativeType(col.type(),
col.precision(), col.scale(), col.length());
Review Comment:
```suggestion
```
Let's use precition/scale from column descriptor directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
