rpuch commented on code in PR #6029:
URL: https://github.com/apache/ignite-3/pull/6029#discussion_r2142279838
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/replication/ZonePartitionReplicaListenerTest.java:
##########
@@ -1466,6 +1464,11 @@ void
writeIntentSwitchForCompactedCatalogTimestampWorks(boolean commit) {
HybridTimestamp beginTs = beginTimestamp(txId);
HybridTimestamp commitTs = clock.now();
+ // We have to force push clock forward because we will invoke listener
directly bypass ReplicaManager or MessageService, so clock
Review Comment:
```suggestion
// We have to force push clock forward because we will invoke
listener directly bypassing ReplicaManager or MessageService, so clock
```
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/replication/ZonePartitionReplicaListenerTest.java:
##########
@@ -1466,6 +1464,11 @@ void
writeIntentSwitchForCompactedCatalogTimestampWorks(boolean commit) {
HybridTimestamp beginTs = beginTimestamp(txId);
HybridTimestamp commitTs = clock.now();
+ // We have to force push clock forward because we will invoke listener
directly bypass ReplicaManager or MessageService, so clock
+ // won't be updated if the test will compute too fast for physical
clock ticking and then we may have equal clock#current and the
Review Comment:
```suggestion
// won't be updated if the test computes too fast for physical clock
ticking and then we may have equal clock#current and the
```
##########
modules/table/src/test/java/org/apache/ignite/internal/table/distributed/replication/ZonePartitionReplicaListenerTest.java:
##########
@@ -1466,6 +1464,11 @@ void
writeIntentSwitchForCompactedCatalogTimestampWorks(boolean commit) {
HybridTimestamp beginTs = beginTimestamp(txId);
HybridTimestamp commitTs = clock.now();
+ // We have to force push clock forward because we will invoke listener
directly bypass ReplicaManager or MessageService, so clock
+ // won't be updated if the test will compute too fast for physical
clock ticking and then we may have equal clock#current and the
+ // given above commit timestamp.
+ clock.update(clock.now().addPhysicalTime(10));
Review Comment:
Why 10? Would just `clock().now()` not be sufficient, without any additions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
