nizhikov commented on code in PR #12134:
URL: https://github.com/apache/ignite/pull/12134#discussion_r2137921376


##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/filename/NodeFileTree.java:
##########
@@ -229,6 +229,13 @@ public class NodeFileTree extends SharedFileTree {
     private static final FileFilter WAL_SEGMENT_FILE_FILTER = file -> 
!file.isDirectory() &&
         WAL_NAME_PATTERN.matcher(file.getName()).matches();
 
+    /** Pattern for WAL temp files - these files will be cleared at startup. */
+    private static final Pattern WAL_TEMP_NAME_PATTERN = 
U.fixedLengthNumberNamePattern(TMP_WAL_SEG_FILE_EXT);

Review Comment:
   Single usage? If, yes - let's inline it.



##########
modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/filename/NodeFileTree.java:
##########
@@ -229,6 +229,13 @@ public class NodeFileTree extends SharedFileTree {
     private static final FileFilter WAL_SEGMENT_FILE_FILTER = file -> 
!file.isDirectory() &&
         WAL_NAME_PATTERN.matcher(file.getName()).matches();
 
+    /** Pattern for WAL temp files - these files will be cleared at startup. */
+    private static final Pattern WAL_TEMP_NAME_PATTERN = 
U.fixedLengthNumberNamePattern(TMP_WAL_SEG_FILE_EXT);

Review Comment:
   Single usage? If, yes - let's inline it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to