Re: [PR] IGNITE-25297 Throw exception if script transaction block doesn't have a COMMIT statement at the end [ignite-3]

[via GitHub]

korlov42 commented on code in PR #5969:
URL: https://github.com/apache/ignite-3/pull/5969#discussion_r2137732061


##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/sql/ItSqlCommandTest.java:
##########
@@ -175,4 +175,54 @@ void exceptionHandler() {
                 () -> assertErrOutputDoesNotContain("Unknown error")
         );
     }
+
+    @Test
+    @DisplayName("An error should be displayed indicating that the script 
transaction was not completed by the script.")
+    void scriptTxNotFinishedByScript() {
+        String expectedError = "Transaction managed by the script was not 
completed by the script.";

Review Comment:
   I like proposed message more



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org