korlov42 commented on code in PR #6001:
URL: https://github.com/apache/ignite-3/pull/6001#discussion_r2137647171
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/trait/IgniteDistribution.java:
##########
@@ -30,6 +30,18 @@ public interface IgniteDistribution extends RelDistribution {
*/
DistributionFunction function();
+ /** Returns affinity distribution flag value. */
+ boolean isAffinityDistribution();
Review Comment:
does it make sense to rename this to `isTableDistribution` or similar? We
have ticket https://issues.apache.org/jira/browse/IGNITE-23227, but what is the
point to introduce new code using obsolete terms
##########
modules/sql-engine/src/main/java/org/apache/ignite/internal/sql/engine/trait/DistributionTrait.java:
##########
@@ -131,13 +195,15 @@ public boolean equals(Object o) {
/** {@inheritDoc} */
@Override
public int hashCode() {
- return Objects.hash(function, keys);
+ return Objects.hash(function, keys, zoneId);
Review Comment:
I would rather add `tableId` since it's expected to be more selective
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
