valepakh commented on code in PR #5985:
URL: https://github.com/apache/ignite-3/pull/5985#discussion_r2135304351
##########
modules/cli/src/integrationTest/java/org/apache/ignite/internal/cli/commands/configuration/ItConfigCommandTest.java:
##########
@@ -157,8 +158,11 @@ void addConfigFromFileAndMergeFromArgs() {
void addConfigFromNonExistingFile() {
execute("cluster", "config", "update", "--url", NODE_URL, "--file",
"wrongPath");
+ if (getCommandClass().equals(TopLevelCliCommand.class)) {
+ assertAll(() -> assertExitCodeIs(1));
+ }
+
assertAll(
- () -> assertExitCodeIs(1),
Review Comment:
Let's use `assertExitCodeIsZero` here and override `errorExitCode` in the
REPL test instead.
##########
modules/cli/src/main/java/org/apache/ignite/internal/cli/commands/cluster/config/ClusterConfigUpdateReplCommand.java:
##########
@@ -38,9 +44,13 @@ public class ClusterConfigUpdateReplCommand extends
BaseCommand implements Runna
@Mixin
private ClusterUrlMixin clusterUrl;
- /** Configuration that will be updated. */
+ /** Configuration from CLI that will be updated. */
@Mixin
- private SpacedParameterMixin config;
+ private SpacedParameterMixin configFromArgs;
+
+ /** Configuration from file that will be updated. */
+ @Option(names = CONFIG_UPDATE_FILE_OPTION, description =
CONFIG_UPDATE_FILE_OPTION_DESC)
+ private File configFile;
Review Comment:
Looks like this option can be moved to the mixin and `formUpdateConfig` from
the `ConfigUtils` can be moved there as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
