timoninmaxim commented on code in PR #12119:
URL: https://github.com/apache/ignite/pull/12119#discussion_r2134793741


##########
modules/core/src/main/java/org/apache/ignite/internal/IgniteDiagnosticMessage.java:
##########
@@ -222,49 +222,53 @@ public boolean request() {
     /**
      *
      */
-    public abstract static class DiagnosticBaseClosure implements 
IgniteBiInClosure<StringBuilder, GridKernalContext> {
+    public abstract static class DiagnosticBaseInfo {
         /**
-         * @return Key to group similar messages.
+         * @param other Another info of the same type.
          */
-        public Object mergeKey() {
-            return getClass();
+        public void merge(DiagnosticBaseInfo other) {

Review Comment:
   Just `abstract void merge`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to