Vladsz83 commented on code in PR #12037:
URL: https://github.com/apache/ignite/pull/12037#discussion_r2126325515


##########
modules/calcite/src/test/sql/function/numeric/test_invalid_math.test:
##########
@@ -7,13 +7,17 @@ SELECT SQRT(-1), SQRT(0)
 ----
 NaN    0.000000
 
-query RRRR
-SELECT LN(-1), LN(0), LOG10(-1), LOG10(0)
-----
-NaN
--Infinity
-NaN
--Infinity
+statement error
+SELECT LN(-1)
+
+statement error
+SELECT LN(0)
+
+statement error
+SELECT LOG10(-1)
+
+statement error
+SELECT LOG10(0)

Review Comment:
   The others functions probably should fixed too. Implemented in 
Postgres-style. It raises errors like 'ERROR:  cannot take logarithm of zero'



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to