tkalkirill commented on code in PR #5940:
URL: https://github.com/apache/ignite-3/pull/5940#discussion_r2123717837
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/compaction/Compactor.java:
##########
@@ -121,11 +122,12 @@ public Compactor(
threadPoolExecutor = new ThreadPoolExecutor(
threadCount,
threadCount,
- 30_000,
- MILLISECONDS,
+ 30,
+ SECONDS,
new LinkedBlockingQueue<>(),
new NamedThreadFactory("compaction-runner-io", log)
Review Comment:
Maybe add nodeName?
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpointer.java:
##########
@@ -226,7 +226,7 @@ public class Checkpointer extends IgniteWorker {
checkpointWritePagesPool = new ThreadPoolExecutor(
checkpointWritePageThreads,
checkpointWritePageThreads,
- 30_000,
+ 0L,
MILLISECONDS,
new LinkedBlockingQueue<>(),
new NamedThreadFactory(CHECKPOINT_RUNNER_THREAD_PREFIX +
"-io", log)
Review Comment:
Maybe add nodeName ?
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/Checkpointer.java:
##########
@@ -226,7 +226,7 @@ public class Checkpointer extends IgniteWorker {
checkpointWritePagesPool = new ThreadPoolExecutor(
Review Comment:
Maybe we can use `Executors#newFixedThreadPool`?
##########
modules/replicator/src/main/java/org/apache/ignite/internal/replicator/ReplicaManager.java:
##########
@@ -292,14 +292,17 @@ public ReplicaManager(
NamedThreadFactory.create(nodeName,
"scheduled-idle-safe-time-sync-thread", LOG)
);
- throttledLogExecutor = new ThreadPoolExecutor(
+ var executor = new ThreadPoolExecutor(
Review Comment:
Maybe we can do without the extra variable with a generalized name? Or
rename it to `throttledLogExecutorInternal`.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/gc/MvGc.java:
##########
@@ -103,14 +103,17 @@ public void start() {
inBusyLock(() -> {
int threadCount = gcConfig.threads().value();
- executor = new ThreadPoolExecutor(
+ var threadPoolExecutor = new ThreadPoolExecutor(
Review Comment:
Same about variable name.
##########
modules/table/src/main/java/org/apache/ignite/internal/table/distributed/TableManager.java:
##########
@@ -586,14 +586,17 @@ public TableManager(
int cpus = Runtime.getRuntime().availableProcessors();
- incomingSnapshotsExecutor = new ThreadPoolExecutor(
+ var executor = new ThreadPoolExecutor(
Review Comment:
Same about variable.
##########
modules/page-memory/src/main/java/org/apache/ignite/internal/pagememory/persistence/checkpoint/CheckpointWorkflow.java:
##########
@@ -144,12 +143,8 @@ public CheckpointWorkflow(
);
if (checkpointThreads > 1) {
- callbackListenerThreadPool = new ThreadPoolExecutor(
+ callbackListenerThreadPool = Executors.newFixedThreadPool(
checkpointThreads,
- checkpointThreads,
- 30_000,
- MILLISECONDS,
- new LinkedBlockingQueue<>(),
new NamedThreadFactory(CHECKPOINT_RUNNER_THREAD_PREFIX +
"-io", LOG)
Review Comment:
Maybe add nodeName ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
