anton-vinogradov commented on code in PR #12117:
URL: https://github.com/apache/ignite/pull/12117#discussion_r2123569659
##########
modules/core/src/main/java/org/apache/ignite/dump/DumpReader.java:
##########
@@ -113,22 +117,13 @@ public DumpReader(DumpReaderConfiguration cfg,
IgniteLogger log) {
cnsmr.onTypes(dump.types());
- Map<Integer, List<String>> grpToNodes = new HashMap<>();
-
- Set<Integer> cacheGrpIds = cfg.cacheGroupNames() != null
- ?
Arrays.stream(cfg.cacheGroupNames()).map(CU::cacheId).collect(Collectors.toSet())
+ Set<Integer> cacheIds = cfg.cacheNames() != null
Review Comment:
`cacheIds` can be inlined to the groupsConfigs
##########
modules/core/src/main/java/org/apache/ignite/dump/DumpReader.java:
##########
@@ -160,7 +155,7 @@ public DumpReader(DumpReaderConfiguration cfg, IgniteLogger
log) {
return;
}
- try (DumpedPartitionIterator iter =
dump.iterator(node, grp, part)) {
+ try (DumpedPartitionIterator iter =
dump.iterator(node, grp, part, cacheIds)) {
Review Comment:
Should be used `e.cacheIds` instead of grp/cacheIds?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@ignite.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
